Skip to content

Farzin/Routing#10236

Merged
balakrishna-deriv merged 2 commits intoderiv-com:masterfrom
farzin-deriv:farzin/routes
Sep 22, 2023
Merged

Farzin/Routing#10236
balakrishna-deriv merged 2 commits intoderiv-com:masterfrom
farzin-deriv:farzin/routes

Conversation

@farzin-deriv
Copy link
Contributor

@farzin-deriv farzin-deriv commented Sep 22, 2023 •
edited
Loading

Changes:

Added routing to the wallet project without touching core and shared package.

@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 22, 2023 9:28am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10236](https://github.com/binary-com/deriv-app/pull/10236)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farzin-deriv-farzin-routes.binary.sx?qa_server=red.binaryws.com&app_id=24186
    - **Original**: https://deriv-app-git-fork-farzin-deriv-farzin-routes.binary.sx
- **App ID**: `24186`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farzin-deriv-farzin-routes.binary.sx/

@coveralls
Copy link

coveralls commented Sep 22, 2023

Coverage Status

coverage: 10.674% (-0.007%) from 10.681% when pulling d86a36b on farzin-deriv:farzin/routes into 0e24aac on binary-com:master.

@farzin-deriv farzin-deriv marked this pull request as ready for review September 22, 2023 06:36
adrienne-deriv
adrienne-deriv approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

balakrishna-deriv
balakrishna-deriv reviewed Sep 22, 2023
View reviewed changes
@balakrishna-deriv balakrishna-deriv merged commit 2c0b85d into deriv-com:master Sep 22, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farzin-deriv farzin-deriv deleted the farzin/routes branch September 22, 2023 09:20
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@farzin-deriv @vinu-deriv
Farzin/Routing (#10236)
17d1144 
* feat(wallet): clean-up

* feat(wallet): clean-up

---------

Co-authored-by: Farzin <farzin@deriv.com>
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@farzin-deriv @vinu-deriv
Farzin/Routing (#10236)
9d8594f 
* feat(wallet): clean-up

* feat(wallet): clean-up

---------

Co-authored-by: Farzin <farzin@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

+3 more reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@farzin-deriv @coveralls @balakrishna-deriv @adrienne-deriv @thisyahlen-deriv @farhan-nurzi-deriv