Skip to content

Conversation

@shafin-deriv
Copy link
Contributor

@shafin-deriv shafin-deriv commented Sep 29, 2023

Changes:

  • We need to show a snack bar message if the bot is running and the user tries to update the strategy
  • A generic snack bar component is added
  • On the bot builder component a workspace onChange listener is added if the bot is running and there is no active listener registered yet
  • The snack bar message is shown to the user if there is any change received from the listener
  • The listener is removed if the bot is not running or the user moves away from the component

Screenshot:
Screenshot 2023-09-29 at 3 59 19 PM

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 4, 2023 2:52am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10393](https://github.com/binary-com/deriv-app/pull/10393)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-243chore-noti-3768a4.binary.sx?qa_server=red.binaryws.com&app_id=32815
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-243chore-noti-3768a4.binary.sx
- **App ID**: `32815`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 86
🟧 Best practices 83
🟢 SEO 92
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-243chore-noti-3768a4.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 11.271% (+0.004%) from 11.267% when pulling d9fb6d2 on shafin-deriv:shafin/BOT-243/chore--notify-users-on-running-bot-change into 07e59fc on binary-com:master.

@markw-deriv
Copy link
Contributor

What does this looks like? Can you add a screenshot of the snackbar?

@shafin-deriv
Copy link
Contributor Author

What does this looks like? Can you add a screenshot of the snackbar?

Sure @markwylde-deriv! Added to the top.

sandeep-deriv
sandeep-deriv previously approved these changes Oct 2, 2023
vinu-deriv
vinu-deriv previously approved these changes Oct 2, 2023
@shafin-deriv shafin-deriv dismissed stale reviews from vinu-deriv and sandeep-deriv via ad077df October 4, 2023 02:38
@gitguardian
Copy link

gitguardian bot commented Oct 4, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 9983eec nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@vinu-deriv vinu-deriv merged commit 1e73722 into deriv-com:master Oct 11, 2023
vinu-deriv added a commit that referenced this pull request Oct 13, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
* chore: show snackbar if strategy changed while running bot

* chore: added test cases

* fix: notification icon

* fix: remove timer if mouse over

* fix: update notification timer on everytime the snackbar opens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants