Skip to content

Conversation

@shafin-deriv
Copy link
Contributor

Changes:

  • Add localize to the snack bar message for translation

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 13, 2023 7:34am

@gitguardian
Copy link

gitguardian bot commented Oct 13, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 9983eec nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10669](https://github.com/binary-com/deriv-app/pull/10669)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-243chore-noti-3768a4.binary.sx?qa_server=red.binaryws.com&app_id=32883
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-243chore-noti-3768a4.binary.sx
- **App ID**: `32883`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-243chore-noti-3768a4.binary.sx/

markw-deriv
markw-deriv previously approved these changes Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Generating Lighthouse report...

@shafin-deriv shafin-deriv changed the base branch from test-coverage-dbot to master October 17, 2023 02:47
@shafin-deriv shafin-deriv dismissed markw-deriv’s stale review October 17, 2023 02:47

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants