Skip to content

[42069] thisyahlen/chore: move useWalletMigration to api package #10690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2023
Merged

[42069] thisyahlen/chore: move useWalletMigration to api package #10690

merged 2 commits into from
Oct 16, 2023

Conversation

@thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Oct 16, 2023 •
edited
Loading

Changes:

  1. Moved useWalletMigration hook to api package

Screenshots:

Please provide some screenshots of the change.

@thisyahlen-deriv thisyahlen-deriv requested a review from a user October 16, 2023 01:40
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 16, 2023 2:31am

@thisyahlen-deriv thisyahlen-deriv changed the title thisyahlen/chore: move useWalletMigration to api package [42069] thisyahlen/chore: move useWalletMigration to api package Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10690](https://github.com/binary-com/deriv-app/pull/10690)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-moveusewa-b2c200.binary.sx?qa_server=red.binaryws.com&app_id=31547
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-moveusewa-b2c200.binary.sx
- **App ID**: `31547`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-moveusewa-b2c200.binary.sx/

ghost
ghost reviewed Oct 16, 2023
View reviewed changes
packages/api/src/hooks/index.ts
export { default as useTransferBetweenAccounts } from './useTransferBetweenAccounts';
export { default as useWalletAccountsList } from './useWalletAccountsList';
export { default as useVerifyEmail } from './useVerifyEmail';
export { default as useWalletMigration } from './useWalletMigration';
Copy link

@ghost ghost Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does imports needs to be updated too?

Copy link
Contributor Author

@thisyahlen-deriv thisyahlen-deriv Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeaps

@coveralls
Copy link

coveralls commented Oct 16, 2023 •
edited
Loading

Coverage Status

coverage: 25.596% (-0.004%) from 25.6% when pulling 6ec3f03 on thisyahlen-deriv:thisyahlen/move_useWalletMigration_to_api into c6926ae on binary-com:master.

yashim-deriv
yashim-deriv requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are functions, should be named as such

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yashim-deriv yashim-deriv merged commit 9c6fe66 into deriv-com:master Oct 16, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@thisyahlen-deriv @vinu-deriv
thisyahlen/chore: move useWalletMigration to api package (#10690)
337cefe 
* chore: move useWalletMigration to api package

* chore: rename to camelcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thisyahlen-deriv @coveralls @yashim-deriv