Skip to content

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Oct 17, 2023

Screenshots:

Screenshot 2023-10-18 at 3 52 30 PM 1

Changes:

✅ Created component for Text Field for wallets.
✅ Added based props for different variations: Normal, Icon, Helper Message, Character Limit.

@aizad-deriv aizad-deriv requested a review from a user October 17, 2023 07:21
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 18, 2023 9:59am

@aizad-deriv aizad-deriv changed the title chore: added Wallet TextField component WALL-2169: Base Components - Input Oct 17, 2023
@coveralls
Copy link

coveralls commented Oct 17, 2023

Coverage Status

coverage: 25.979%. remained the same when pulling dcec3bb on aizad-deriv:aizad/input-element into 322162f on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10743](https://github.com/binary-com/deriv-app/pull/10743)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-input-element.binary.sx?qa_server=red.binaryws.com&app_id=23878
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-input-element.binary.sx
- **App ID**: `23878`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-input-element.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost ghost merged commit a0e3728 into deriv-com:master Oct 18, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants