Skip to content

[Wallet] Lubega / WALL-2293 / Base component divider #10856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2023
Merged

[Wallet] Lubega / WALL-2293 / Base component divider #10856

merged 3 commits into from
Oct 23, 2023

Conversation

@lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Oct 23, 2023

Changes:

  • Added reusable base component Divider
  • Added orientation and margin properties to the Divider component

@lubega-deriv lubega-deriv requested a review from a user October 23, 2023 02:21
@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 23, 2023 2:56am

thisyahlen-deriv
thisyahlen-deriv reviewed Oct 23, 2023
View reviewed changes
thisyahlen-deriv
thisyahlen-deriv reviewed Oct 23, 2023
View reviewed changes
thisyahlen-deriv
thisyahlen-deriv reviewed Oct 23, 2023
View reviewed changes
farhan-nurzi-deriv
farhan-nurzi-deriv reviewed Oct 23, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Oct 23, 2023 •
edited
Loading

Coverage Status

coverage: 26.282% (-0.003%) from 26.285% when pulling 9326fd6 on lubega-deriv:WALL-2293/base-component-divider-2 into c3fc904 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10856](https://github.com/binary-com/deriv-app/pull/10856)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-2293-base-component-504eb1.binary.sx?qa_server=red.binaryws.com&app_id=32193
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-2293-base-component-504eb1.binary.sx
- **App ID**: `32193`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-2293-base-component-504eb1.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@balakrishna-deriv balakrishna-deriv merged commit 9fd1115 into deriv-com:master Oct 23, 2023
aum-deriv pushed a commit to aum-deriv/deriv-app that referenced this pull request Oct 23, 2023
@lubega-deriv @aum-deriv
[Wallet] Lubega / WALL-2293 / Base component divider (deriv-com#10856)
b292fdb 
* feat: added base component divider

* fix: resolved comments

* fix: resolved comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

+2 more reviewers

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lubega-deriv @coveralls @balakrishna-deriv @thisyahlen-deriv @farhan-nurzi-deriv