Skip to content

[Wallets] adrienne / Transformed px to rem #10881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 24, 2023
Merged

[Wallets] adrienne / Transformed px to rem #10881

merged 9 commits into from
Oct 24, 2023

Conversation

@adrienne-deriv
Copy link
Contributor

@adrienne-deriv adrienne-deriv commented Oct 23, 2023

Changes:

Please provide a summary of the change.

  • Used codemod to transform px to remfor wallets

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 24, 2023 9:05am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10881](https://github.com/binary-com/deriv-app/pull/10881)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-refactor-px-to-rem-draft.binary.sx?qa_server=red.binaryws.com&app_id=24100
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-refactor-px-to-rem-draft.binary.sx
- **App ID**: `24100`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-refactor-px-to-rem-draft.binary.sx/

@adrienne-deriv adrienne-deriv marked this pull request as ready for review October 24, 2023 01:50
@adrienne-deriv adrienne-deriv requested a review from a user October 24, 2023 01:50
@coveralls
Copy link

coveralls commented Oct 24, 2023 •
edited
Loading

Coverage Status

coverage: 26.753%. remained the same when pulling 079a3c5 on adrienne-deriv:refactor-px-to-rem-draft into 0f47fbd on binary-com:master.

@mahdiyeh-deriv mahdiyeh-deriv mentioned this pull request Oct 24, 2023
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@yashim-deriv yashim-deriv merged commit c2f0eed into deriv-com:master Oct 24, 2023
likhith-deriv pushed a commit to likhith-deriv/deriv-app that referenced this pull request Oct 25, 2023
@adrienne-deriv @likhith-deriv
adrienne/feat: transformed px to rem (deriv-com#10881)
4ea32a3 
* chore: added transformer to transform px to rem

* chore: fix merge conflicts

* chore: fixed eslint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

+2 more reviewers

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrienne-deriv @coveralls @yashim-deriv @thisyahlen-deriv @farhan-nurzi-deriv