Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

Changes:

Screenshots:

Screenshot 2023-10-25 at 3 30 44 PM

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 25, 2023 7:47am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 26.721%. remained the same when pulling ae67271 on thisyahlen-deriv:thisyahlen/verification_status_for_mt5 into b66ad9b on binary-com:master.

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10947](https://github.com/binary-com/deriv-app/pull/10947)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-verificat-4df301.binary.sx?qa_server=red.binaryws.com&app_id=32694
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-verificat-4df301.binary.sx
- **App ID**: `32694`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-verificat-4df301.binary.sx/

align-items: center;

&--close-icon {
&-close-icon {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if its block, then it should be __close-icon,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants