Skip to content

Conversation

@akmal-deriv
Copy link
Contributor

Changes:

This pull request (PR) presents a new feature that involves replacing the current responsive longcode user interface (UI) with a modal. This update is likely aimed at enhancing the user experience and interface design by switching from a longcode format to a more streamlined and efficient modal UI.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 14, 2023 4:29am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11038](https://github.com/binary-com/deriv-app/pull/11038)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-akmal-deriv-f-longcode-updates.binary.sx?qa_server=red.derivws.com&app_id=32941
    - **Original**: https://deriv-app-git-fork-akmal-deriv-f-longcode-updates.binary.sx
- **App ID**: `32941`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-longcode-updates.binary.sx/

maryia-deriv
maryia-deriv previously approved these changes Nov 9, 2023
maryia-deriv
maryia-deriv previously approved these changes Nov 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@akmal-deriv akmal-deriv changed the title Akmal / feat: replace existing responsive longcode UI with a modal [dtra] Akmal / feat: replace existing responsive longcode UI with a modal Nov 14, 2023
@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@balakrishna-deriv balakrishna-deriv merged commit 5a6f2f4 into deriv-com:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants