Skip to content

Conversation

@ali-hosseini-deriv
Copy link
Contributor

@ali-hosseini-deriv ali-hosseini-deriv commented Oct 30, 2023

Changes:

We have an issue on core package that it has a bundle from p2p which is 34 MB. this is to fix that issue.

before

image

After

image

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 30, 2023 9:32am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11042](https://github.com/binary-com/deriv-app/pull/11042)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-maintain-core-7e2399.binary.sx?qa_server=red.derivws.com&app_id=32186
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-maintain-core-7e2399.binary.sx
- **App ID**: `32186`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-maintain-core-7e2399.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 27.142% (+0.004%) from 27.138% when pulling 59472a4 on ali-hosseini-deriv:ako/maintain-core-bundle-size into 543a5d0 on binary-com:master.

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farrah-deriv would you have a look.

@ali-hosseini-deriv ali-hosseini-deriv merged commit a220203 into deriv-com:master Oct 30, 2023
ali-hosseini-deriv added a commit that referenced this pull request Oct 31, 2023
ali-hosseini-deriv added a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants