Skip to content

Conversation

@aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Oct 30, 2023

Changes:

Fixes:

  1. Removed . from DepositCryptoCurrencyDetails.
  2. Fixed padding-top for the crypto-deposit in desktop and responsive.
  3. Updated sentence in disclaimer: "Do not send other currencies to this address." to "Do not send other cryptocurrencies to this address."
  4. Fixed the text-overflow: ellipses for the crypto-address.
  5. Created the Tooltip component for the showing 'Copy/Copied` when hovered over clipboard.
  6. Fixed the Copied icon with the correct one for the clipboard.
  7. Made the link-text's font-weight as normal for Try Fiat Onramp link.

Extras:

  1. Added loader for WalletCashier and DepositFiatModule.
  2. Added skeleton loader for deposit crypto QR code and transaction-status

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 1, 2023 7:06am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11053](https://github.com/binary-com/deriv-app/pull/11053)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-2368fix-wallet-cry-c4a162.binary.sx?qa_server=red.derivws.com&app_id=32507
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-2368fix-wallet-cry-c4a162.binary.sx
- **App ID**: `32507`

@coveralls
Copy link

coveralls commented Oct 30, 2023

Coverage Status

coverage: 27.159%. remained the same when pulling 9fcb6d0 on aum-deriv:aum/WALL-2368/fix-wallet-crypto-deposit-issues into 6049960 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-2368fix-wallet-cry-c4a162.binary.sx/

ghost
ghost previously approved these changes Oct 30, 2023
nijil-deriv
nijil-deriv previously approved these changes Oct 31, 2023
ghost
ghost previously approved these changes Oct 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@nijil-deriv nijil-deriv merged commit d48a485 into deriv-com:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants