-
Notifications
You must be signed in to change notification settings - Fork 394
[Wallets] Sergei / wall 2301 / Switch CFDs to Options&Multipliers and back #11143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallets] Sergei / wall 2301 / Switch CFDs to Options&Multipliers and back #11143
Conversation
…add-onboarding-steps
… sergei/wall-2128/add-onboarding-steps
…implement-simple-onboarding-step
… sergei/wall-2128/add-onboarding-steps
… sergei/wall-2128/add-onboarding-steps
…add-onboarding-steps
…add-onboarding-steps
…set-onboarding-start-in-localstorage
…add-onboarding-steps
…-2103/autoscroll-onboarding-desktop
…into sergei/wall-2103/autoscroll-onboarding-desktop
packages/wallets/src/components/WalletTourGuide/WalletTourGuideSettings.tsx
Show resolved
Hide resolved
…autoscroll-onboarding-desktop
…rgei/wall-2129/onboarding-steps-for-responsive
…sergei/wall-2301/switch-cfds-to-options-and-back
…switch-cfds-to-options-and-back
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 2d31897 | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
🚀 Smoke test run (2) passed successfully! |
|
🚀 Smoke test run (1) passed successfully! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |








Changes:
This PR extends this PR (onboarding steps for responsive)
Add
WalletMobileTourGuidecomponent and put it inside of theTabscomponentNote: wait for loading CFD (Options&for Multipliers) section DOM elements will be added in the next PR
Video
Switching.tabs.mov