[Wallet] george / WALL-2190 / add TransferAccountSelection component #11192

heorhi-deriv · 2023-11-05T18:48:34Z

Changes:

restructure Transfer folder
refactor TransferAccountSelection, TransferFormAccountCard components according Figma design
add TransferProvider for handling transfer accounts
add missing icons to WalletResponsiveSvg component

Screenshots:

vercel · 2023-11-05T18:48:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Nov 13, 2023 0:29am

packages/api/src/hooks/useTransferAccounts.ts

coveralls · 2023-11-05T19:01:42Z

coverage: 27.646% (+0.3%) from 27.299%
when pulling 354dd33 on heorhi-deriv:WALL-2190-Implement-Transfer-Account-Selection-Component--UI-
into 1129692 on binary-com:master.

github-actions · 2023-11-05T19:04:50Z

A production App ID was automatically generated for this PR. (log)

PR: [Wallet] george / WALL-2190 / add TransferAccountSelection component #11192
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx?qa_server=red.derivws.com&app_id=24112
- Original: https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx
App ID: 24112

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/11192](https://github.com/binary-com/deriv-app/pull/11192)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx?qa_server=red.derivws.com&app_id=24112
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx
- **App ID**: `24112`

github-actions · 2023-11-05T19:05:45Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx/

packages/wallets/src/features/cashier/modules/Transfer/hooks/useWalletTransfer.ts

...r/modules/Transfer/components/TransferFormAccountSelection/TransferFormAccountSelection.scss

packages/wallets/src/features/cashier/modules/Transfer/hooks/useWalletTransfer.ts

...ures/cashier/modules/Transfer/components/TransferFormAccountCard/TransferFormAccountCard.tsx

...er/modules/Transfer/components/TransferFormAccountSelection/TransferFormAccountSelection.tsx

packages/wallets/src/features/cashier/modules/Transfer/types/types.ts

packages/api/src/hooks/useTransferAccounts.ts

...ures/cashier/modules/Transfer/components/TransferFormAccountCard/TransferFormAccountCard.tsx

packages/wallets/src/features/cashier/modules/Transfer/helpers/helpers.ts

packages/wallets/src/features/cashier/modules/Transfer/hooks/useWalletTransfer.ts

nijil-deriv

@george-usynin-deriv I don't think TransferFormDropdown and TransferFormInputField are modules. TransferForm should be the module and it should be moved out of components directory imo.

…tion-Component--UI-

… WALL-2190-Implement-Transfer-Account-Selection-Component--UI-

github-actions · 2023-11-13T11:09:00Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-13T11:11:57Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-11-13T11:12:06Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-11-13T12:14:00Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-13T12:14:01Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-13T12:14:02Z

🚀 Smoke test run (1) passed successfully!

github-actions · 2023-11-13T12:14:22Z

🚀 Smoke test run (2) passed successfully!

sonarqubecloud · 2023-11-13T12:16:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-11-13T12:27:26Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-13T12:27:28Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-13T12:30:32Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-11-13T12:30:47Z

🚀 Smoke test run (1) passed successfully!

…mponent (#11192)" This reverts commit aa9f2c0.

heorhi-deriv added 2 commits November 4, 2023 18:15

feat: ✨ add transfer account list

001cf3f

feat: ✨ add transfer hint, fix demo bg

ae79f78

heorhi-deriv deployed to Preview November 5, 2023 18:49 — with GitHub Actions Active

heorhi-deriv deployed to Preview November 5, 2023 18:49 — with GitHub Actions View deployment

heorhi-deriv commented Nov 5, 2023

View reviewed changes

packages/api/src/hooks/useTransferAccounts.ts Outdated Show resolved Hide resolved

heorhi-deriv commented Nov 5, 2023

View reviewed changes

packages/wallets/src/features/cashier/modules/Transfer/hooks/useWalletTransfer.ts Show resolved Hide resolved

fix: 🚑 sonarcloud bug

94bcc8c

heorhi-deriv deployed to Preview November 5, 2023 19:20 — with GitHub Actions Active

heorhi-deriv deployed to Preview November 5, 2023 19:21 — with GitHub Actions View deployment

heorhi-deriv marked this pull request as ready for review November 5, 2023 19:33

heorhi-deriv requested review from adrienne-deriv, farhan-nurzi-deriv and thisyahlen-deriv as code owners November 5, 2023 19:33

heorhi-deriv requested a review from a user November 5, 2023 19:33

rostislav-deriv reviewed Nov 5, 2023

View reviewed changes

...ures/cashier/modules/Transfer/components/TransferFormAccountCard/TransferFormAccountCard.tsx Outdated Show resolved Hide resolved

thisyahlen-deriv reviewed Nov 6, 2023

View reviewed changes

...er/modules/Transfer/components/TransferFormAccountSelection/TransferFormAccountSelection.tsx Outdated Show resolved Hide resolved

thisyahlen-deriv reviewed Nov 6, 2023

View reviewed changes

packages/wallets/src/features/cashier/modules/Transfer/types/types.ts Outdated Show resolved Hide resolved

farhan-nurzi-deriv reviewed Nov 6, 2023

View reviewed changes

packages/api/src/hooks/useTransferAccounts.ts Outdated Show resolved Hide resolved

ghost reviewed Nov 7, 2023

View reviewed changes

...ures/cashier/modules/Transfer/components/TransferFormAccountCard/TransferFormAccountCard.tsx Outdated Show resolved Hide resolved

ghost reviewed Nov 7, 2023

View reviewed changes

packages/wallets/src/features/cashier/modules/Transfer/helpers/helpers.ts Show resolved Hide resolved

ghost reviewed Nov 7, 2023

View reviewed changes

packages/wallets/src/features/cashier/modules/Transfer/hooks/useWalletTransfer.ts Show resolved Hide resolved

ghost previously approved these changes Nov 7, 2023

View reviewed changes

nijil-deriv reviewed Nov 7, 2023

View reviewed changes

Merge branch 'master' into WALL-2190-Implement-Transfer-Account-Selec…

dc9515f

…tion-Component--UI-

heorhi-deriv dismissed ghost ’s stale review via dc9515f November 8, 2023 07:32

heorhi-deriv dismissed ghost ’s stale review via f37b2ba November 11, 2023 20:09

heorhi-deriv deployed to Preview November 11, 2023 20:11 — with GitHub Actions Active

heorhi-deriv deployed to Preview November 11, 2023 20:11 — with GitHub Actions View deployment

heorhi-deriv added 2 commits November 13, 2023 12:44

refactor: ♻️ wrap TransferForm with provider inside the module itself

17d39e0

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

4c285bf

… WALL-2190-Implement-Transfer-Account-Selection-Component--UI-

heorhi-deriv deployed to Preview November 13, 2023 09:52 — with GitHub Actions View deployment

heorhi-deriv deployed to Preview November 13, 2023 09:52 — with GitHub Actions Active

refactor: ♻️ rename transferformmodule to transfer

ccc519f

heorhi-deriv deployed to Preview November 13, 2023 10:54 — with GitHub Actions Active

heorhi-deriv deployed to Preview November 13, 2023 10:54 — with GitHub Actions View deployment

refactor: ♻️ refactor name

354dd33

heorhi-deriv deployed to Preview November 13, 2023 12:13 — with GitHub Actions Active

heorhi-deriv deployed to Preview November 13, 2023 12:13 — with GitHub Actions View deployment

nijil-deriv approved these changes Nov 13, 2023

View reviewed changes

ghost approved these changes Nov 13, 2023

View reviewed changes

nijil-deriv merged commit aa9f2c0 into deriv-com:master Nov 13, 2023

nijil-deriv added a commit that referenced this pull request Nov 13, 2023

Revert "[Wallet] george / WALL-2190 / add TransferAccountSelection co…

68f81cc

…mponent (#11192)" This reverts commit aa9f2c0.

nijil-deriv mentioned this pull request Nov 13, 2023

Revert "[Wallet] george / WALL-2190 / add TransferAccountSelection component" #11371

Closed

[Wallet] george / WALL-2190 / add TransferAccountSelection component #11192

[Wallet] george / WALL-2190 / add TransferAccountSelection component #11192

Uh oh!

Conversation

heorhi-deriv commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Screenshots:

Uh oh!

vercel bot commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coveralls commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nijil-deriv left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

sonarqubecloud bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

heorhi-deriv commented Nov 5, 2023 •

edited

Loading

vercel bot commented Nov 5, 2023 •

edited

Loading

coveralls commented Nov 5, 2023 •

edited

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading