Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

Changes:

  • Create a feature folder for accounts
  • Implement the fist screen for manual verification (Document Selection)

Screenshots:

Screenshot 2023-11-08 at 3 19 47 PM

@vercel
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 9, 2023 2:37am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11275](https://github.com/binary-com/deriv-app/pull/11275)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-accounts-ma-85f4e2.binary.sx?qa_server=red.derivws.com&app_id=31387
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-accounts-ma-85f4e2.binary.sx
- **App ID**: `31387`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-accounts-ma-85f4e2.binary.sx/

@coveralls
Copy link

coveralls commented Nov 8, 2023

Coverage Status

coverage: 26.687% (+0.1%) from 26.585%
when pulling f7cbc1f on farhan-nurzi-deriv:farhan/accounts-manual-document-upload
into 0202eaa on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚀 Smoke test run (2) passed successfully!

@yashim-deriv yashim-deriv merged commit e58b222 into deriv-com:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants