Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

Changes:

  • Implement the new endpoint to get all available wallets that user can create

Screenshots:

Screen.Recording.2023-11-09.at.11.29.03.AM.mov

@vercel
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 13, 2023 2:25pm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11294](https://github.com/binary-com/deriv-app/pull/11294)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-availablewa-680480.binary.sx?qa_server=red.derivws.com&app_id=32206
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-availablewa-680480.binary.sx
- **App ID**: `32206`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-availablewa-680480.binary.sx/

@coveralls
Copy link

coveralls commented Nov 9, 2023

Coverage Status

coverage: 27.65% (+0.004%) from 27.646%
when pulling 3cebbd8 on farhan-nurzi-deriv:farhan/available_wallets-hook-change
into aa9f2c0 on binary-com:master.

@gitguardian
Copy link

gitguardian bot commented Nov 10, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 3b3ed0b nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

ghost
ghost previously approved these changes Nov 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashim-deriv yashim-deriv merged commit c4bc937 into deriv-com:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants