Skip to content

Conversation

@farabi-deriv
Copy link
Contributor

Changes:

  • Added reverse martingale strategy for quick strategies
  • Added the required fields for reverse martingale to the quick strategy config
  • Added the reverse martingale xml with updated fields

Screenshots:

Screenshot 2023-11-09 at 12 14 29 PM

@vercel
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 9, 2023 4:50am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@coveralls
Copy link

coveralls commented Nov 9, 2023

Coverage Status

coverage: 27.3% (+0.7%) from 26.606%
when pulling 4141136 on farabi-deriv:farabi/bot-155/add-reverse-martingale-strategy
into 32be45b on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11298](https://github.com/binary-com/deriv-app/pull/11298)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-155add-revers-183a3a.binary.sx?qa_server=red.derivws.com&app_id=23879
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-155add-revers-183a3a.binary.sx
- **App ID**: `23879`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-155add-revers-183a3a.binary.sx/

@chrisgodfrey-deriv
Copy link

Please use the [BOT] prefix for the PR title

@farabi-deriv farabi-deriv changed the title Farabi/bot-155/add reverse martingale strategy [BOT] Farabi/bot-155/add reverse martingale strategy Nov 10, 2023
@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@vinu-deriv vinu-deriv merged commit 8e1782a into deriv-com:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants