Skip to content

Conversation

@nada-deriv
Copy link
Contributor

Changes:

This pr is to solve the issue where some files were not getting uploaded in the sendbird chat. It happened for random files. The issue was because of the file name. When uploading screenshots, few file names had non ascii characters and it resulted in an internal server error from sendbird. Solved the issue by formatting the filename before uploading.

Screenshots:

Please provide some screenshots of the change.
Screenshot 2023-11-10 at 11 15 09 AM

@vercel
Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 29, 2023 8:28am

@coveralls
Copy link

coveralls commented Nov 10, 2023

Coverage Status

coverage: 28.988% (-0.005%) from 28.993%
when pulling 76a9ace on nada-deriv:nada/P2PS-1749/sendbird-upload-issue
into c01b20f on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11336](https://github.com/binary-com/deriv-app/pull/11336)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1749sendbird-upl-8181d7.binary.sx?qa_server=red.derivws.com&app_id=32815
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1749sendbird-upl-8181d7.binary.sx
- **App ID**: `32815`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1749sendbird-upl-8181d7.binary.sx/

Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.6% 10.6% Duplication

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@farrah-deriv farrah-deriv merged commit 52bea9e into deriv-com:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants