Skip to content

Conversation

@nijil-deriv
Copy link
Contributor

Changes:

Wallet overlay padding for -
Desktop: 4.8rem padding top, 1.6rem left and right.
Mobile: 2.4rem padding, 1.6rem left and right.

Remove aligning children to center until we have designs finalized.

Also removed unnecessary css.

Screenshots:

Please provide some screenshots of the change.
Screenshot 2023-11-13 at 11 38 38
Screenshot 2023-11-13 at 11 38 54
Screenshot 2023-11-13 at 11 39 12
Screenshot 2023-11-13 at 11 39 27
Screenshot 2023-11-13 at 11 39 52
Screenshot 2023-11-13 at 11 40 04
Screenshot 2023-11-13 at 11 40 17
Screenshot 2023-11-13 at 11 40 37

@vercel
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 13, 2023 8:00am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11361](https://github.com/binary-com/deriv-app/pull/11361)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nijil-deriv-nijil-wall-2526wallet-ove-c3e46b.binary.sx?qa_server=red.derivws.com&app_id=32214
    - **Original**: https://deriv-app-git-fork-nijil-deriv-nijil-wall-2526wallet-ove-c3e46b.binary.sx
- **App ID**: `32214`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-nijil-deriv-nijil-wall-2526wallet-ove-c3e46b.binary.sx/

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@coveralls
Copy link

Coverage Status

coverage: 27.294% (+0.003%) from 27.291%
when pulling b119f7f on nijil-deriv:nijil/wall-2526/wallet-overlay-padding-fix
into 10de418 on binary-com:master.

@nijil-deriv nijil-deriv merged commit a1b09a5 into deriv-com:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants