Skip to content

Conversation

@heorhi-deriv
Copy link
Contributor

Changes:

  • restructure Transfer folder
  • refactor TransferAccountSelection, TransferFormAccountCard components according Figma design
  • add TransferProvider for handling transfer accounts
  • add missing icons to WalletResponsiveSvg component

Screenshots:

Screenshot 2023-11-05 at 21 44 15 Screenshot 2023-11-05 at 21 41 31 Screenshot 2023-11-05 at 21 42 01 Screenshot 2023-11-05 at 21 42 36 Screenshot 2023-11-05 at 21 43 31 Screenshot 2023-11-05 at 21 46 06

heorhi-deriv and others added 21 commits November 4, 2023 18:15
…t--UI-' of github.com:heorhi-deriv/deriv-app into WALL-2190-Implement-Transfer-Account-Selection-Component--UI-
…t--UI-' of github.com:heorhi-deriv/deriv-app into WALL-2190-Implement-Transfer-Account-Selection-Component--UI-
… WALL-2190-Implement-Transfer-Account-Selection-Component--UI-
… WALL-2190-Implement-Transfer-Account-Selection-Component--UI-
@vercel
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 13, 2023 2:07pm

@gitguardian
Copy link

gitguardian bot commented Nov 13, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 77fd241 nx.json View secret
- Generic High Entropy Secret 7826561 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11372](https://github.com/binary-com/deriv-app/pull/11372)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx?qa_server=red.derivws.com&app_id=32208
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx
- **App ID**: `32208`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-2190-implement-tran-073860.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 27.646%. remained the same
when pulling 9781a98 on heorhi-deriv:WALL-2190-Implement-Transfer-Account-Selection-Component--UI-
into aa9f2c0 on binary-com:master.

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants