Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

@hamza-deriv hamza-deriv commented Nov 16, 2023

Changes:

Please provide a summary of the change.

Replace all instances of useCFDStores and WS from CFD components, replace with hooks from packages/api/src/hooks

  • trading-password-manager.tsx
  • investor-password-manager.tsx

Tweak the cfd-password-modal.tsx component to use the hooks instead of stores

Tweak the useTradingPlatformInvestorPasswordChange to have types for mutateAsync

Clickup Card:

[Refactoring] Trading Password Manager component

Screenshots:

Please provide some screenshots of the change.

Before

image

After

image

@vercel
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 20, 2023 2:26am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11504](https://github.com/binary-com/deriv-app/pull/11504)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1417refactorin-384b33.binary.sx?qa_server=red.derivws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1417refactorin-384b33.binary.sx
- **App ID**: `32877`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1417refactorin-384b33.binary.sx/

@coveralls
Copy link

coveralls commented Nov 16, 2023

Coverage Status

coverage: 27.649% (-0.1%) from 27.773%
when pulling 50cf24c on hamza-deriv:hamza/CFDS-1417/refactoring-trading-password-manager
into b3f869e on binary-com:master.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@matin-deriv matin-deriv merged commit 2ae5d67 into deriv-com:master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants