shayan/feq-931/ fixed ts error for OrderedPlatformSections component #11571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayan-deriv
requested review from
mahdiyeh-deriv,
matin-deriv and
nijil-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed!
|
amina-deriv
approved these changes
Nov 20, 2023
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shayan-deriv-shayan-fix-ordered-platf-10a575.binary.sx/ |
Contributor
|
⏳ Generating Lighthouse report... |
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
shayan-deriv
changed the title
jim-deriv
approved these changes
Nov 20, 2023
Contributor
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Merged
shayan-deriv
deleted the
shayan/fix-ordered-platform-sections-props-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had an ts error for
<OrderedPlatformSections/>and to fix it I converted the components props into an object.