Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Description:

This card serves the purpose of crafting an atomic Button Component tailored for the CFD package. Designed with precision, this component ensures seamless integration and optimal functionality withdifferent CFD environments. With a focus on modularity and efficiency, the atomic Button Component enhances the user experience, providing a robust and cohesive interface for CFD-related interactions.

Scope:

  • Add an Atomic Button Component in the features folder.

Expected Behaviour:

An Atomic Button Component is added in the features/Components

  • - Having CTA as separate Components
  • - Have its own sass file
  • - Include the unit tests
  • - Exported as default Button component.

Screenshots:

Please provide some screenshots of the change.

After

image

@vercel
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2023 6:00am

@coveralls
Copy link

coveralls commented Nov 22, 2023

Coverage Status

coverage: 28.12% (+0.01%) from 28.107%
when pulling 57164ee on hamza-deriv:hamza/CFDS-1456/Button-component
into bc09647 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11650](https://github.com/binary-com/deriv-app/pull/11650)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1456button-component.binary.sx?qa_server=red.derivws.com&app_id=24200
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1456button-component.binary.sx
- **App ID**: `24200`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1456button-component.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants