[P2PS]-fix: issue where reason was not listed for fixed-to-float or viceversa#11674
Merged
farrah-deriv merged 1 commit intoderiv-com:masterfrom Dec 12, 2023
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
🚀 Smoke test run (1) passed successfully! |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1949float-to-fix-2e801c.binary.sx/ |
Contributor
|
🚀 Smoke test run (2) passed successfully! |
farrah-deriv
approved these changes
Nov 22, 2023
ameerul-deriv
approved these changes
Nov 23, 2023
niloofar-deriv
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Currently when an ad is in floating rate, and in BO the rate is changed to fixed rate, or ad is in fixed and in BO the rate is changed to floating rate, the indication for the hidden ad will not be given. Its because the reason is determined based on the code obtained from the <visibility_status> field which appears only when the cron job is run. In production since the cron job is run only once in 24 hours, by any chance if the rate is changed and cron job is not run, the reason will not be visible. This PR fixes the issue by manually stating the reason until the value is received from BE.
Screenshots:
Please provide some screenshots of the change.