Skip to content

[P2PS]-fix: issue where reason was not listed for fixed-to-float or viceversa#11674

Merged
farrah-deriv merged 1 commit intoderiv-com:masterfrom
nada-deriv:nada/P2PS-1949/float-to-fixed-indication-issue
Dec 12, 2023
Merged

[P2PS]-fix: issue where reason was not listed for fixed-to-float or viceversa#11674
farrah-deriv merged 1 commit intoderiv-com:masterfrom
nada-deriv:nada/P2PS-1949/float-to-fixed-indication-issue

Conversation

@nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Nov 22, 2023

Currently when an ad is in floating rate, and in BO the rate is changed to fixed rate, or ad is in fixed and in BO the rate is changed to floating rate, the indication for the hidden ad will not be given. Its because the reason is determined based on the code obtained from the <visibility_status> field which appears only when the cron job is run. In production since the cron job is run only once in 24 hours, by any chance if the rate is changed and cron job is not run, the reason will not be visible. This PR fixes the issue by manually stating the reason until the value is received from BE.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2023 9:42am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
12.4% 12.4% Duplication

@coveralls
Copy link

coveralls commented Nov 22, 2023

Coverage Status

coverage: 28.205%. remained the same
when pulling 8f7f5c3 on nada-deriv:nada/P2PS-1949/float-to-fixed-indication-issue
into 1d26258 on binary-com:master.

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11674](https://github.com/binary-com/deriv-app/pull/11674)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1949float-to-fix-2e801c.binary.sx?qa_server=red.derivws.com&app_id=31560
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1949float-to-fix-2e801c.binary.sx
- **App ID**: `31560`

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1949float-to-fix-2e801c.binary.sx/

@github-actions
Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

@farrah-deriv farrah-deriv merged commit e724700 into deriv-com:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants