Skip to content

Conversation

@nada-deriv
Copy link
Contributor

Changes:

This PR is for removing the unused observables and functions in general-store.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 23, 2023 7:51am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.6% 11.6% Duplication

@coveralls
Copy link

Coverage Status

coverage: 28.191% (+0.006%) from 28.185%
when pulling a73331c on nada-deriv:nada/P2PS-1928/general-store-remove-unused
into 532d47b on binary-com:master.

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11703](https://github.com/binary-com/deriv-app/pull/11703)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1928general-stor-e3b4cf.binary.sx?qa_server=red.derivws.com&app_id=32126
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1928general-stor-e3b4cf.binary.sx
- **App ID**: `32126`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1928general-stor-e3b4cf.binary.sx/

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

Copy link
Contributor

@markw-deriv markw-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love removing stuff from these stores 😍

@farrah-deriv farrah-deriv merged commit c1e2a54 into deriv-com:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants