Skip to content

Conversation

@heorhi-deriv
Copy link
Contributor

Changes:

Implement next rules for account selection in transfer section:

  1. We reset the amount inputs only if transfer from_account is changed.
  2. If selected to_account equals current from_account and vice versa, we swap/interchange accounts and amounts.
  3. If the user selected to_account, from_amount will stay the same and to_amount will be recalculated accordingly depending on to_account_currency.
  4. If the user selects the same account, no changes are made to the existing accounts and amounts.

@vercel
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 27, 2023 8:48pm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11807](https://github.com/binary-com/deriv-app/pull/11807)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-fix-inputs.binary.sx?qa_server=red.derivws.com&app_id=31227
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-fix-inputs.binary.sx
- **App ID**: `31227`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-fix-inputs.binary.sx/

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 28.953% (+0.002%) from 28.951%
when pulling e710488 on heorhi-deriv:fix-inputs
into 714d4d6 on binary-com:master.

@heorhi-deriv heorhi-deriv merged commit 0fb1225 into deriv-com:master Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants