Skip to content

Conversation

@matin-deriv
Copy link
Contributor

@matin-deriv matin-deriv commented Nov 28, 2023

Changes:

This code is designed to eliminate the reality check modal and all associated code from the codebase. Initially, we had this modal exclusively for MX and MLT broker codes, triggered by the is_reality_check variable in the API. Given that we no longer support those broker codes, it is safe to tidy up the code.

Screenshots:

Screenshot 2023-11-28 at 5 54 30 PM

@vercel
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 29, 2023 3:08am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11820](https://github.com/binary-com/deriv-app/pull/11820)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-matin-deriv-matin-realitycheck.binary.sx?qa_server=red.derivws.com&app_id=23813
    - **Original**: https://deriv-app-git-fork-matin-deriv-matin-realitycheck.binary.sx
- **App ID**: `23813`

@coveralls
Copy link

coveralls commented Nov 28, 2023

Coverage Status

coverage: 29.059% (+0.06%) from 29.001%
when pulling 848ddaf on matin-deriv:matin/reality_check
into 3af6f97 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-matin-deriv-matin-realitycheck.binary.sx/

@matin-deriv matin-deriv changed the title WALL-2785/Matin/Reality check modal removal [WALL] Matin/2785/Reality check modal removal Nov 28, 2023
yashim-deriv
yashim-deriv previously approved these changes Nov 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.6% 9.6% Duplication

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

Generating Lighthouse report...

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love code removal PRs <3

@matin-deriv matin-deriv merged commit 1b464bc into deriv-com:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants