Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 1, 2023

Added example component tests for crypto withdrawal component.

In ideal world, I should be able to test component itself without rendering the whole page, but given thats not viable (or, it would require massive effort in mocking given current component structure), playwright can effectively be used for component testing. Hopefully over next iterations we gonna build better component structure, which can actually be tested on component level as it should be.

@vercel
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 6, 2023 0:14am

@ghost ghost temporarily deployed to Preview December 1, 2023 11:36 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 1, 2023 11:36 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11959](https://github.com/binary-com/deriv-app/pull/11959)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-component-test-bd4020.binary.sx?qa_server=red.derivws.com&app_id=32100
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-component-test-bd4020.binary.sx
- **App ID**: `32100`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-component-test-bd4020.binary.sx/

@ghost ghost temporarily deployed to Preview December 1, 2023 13:23 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 1, 2023 13:23 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 1, 2023 13:27 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 1, 2023 13:27 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 1, 2023 15:09 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 1, 2023 15:09 — with GitHub Actions Inactive
markw-deriv
markw-deriv previously approved these changes Dec 4, 2023
@ghost ghost mentioned this pull request Dec 4, 2023
4 tasks
@ghost ghost temporarily deployed to Preview December 6, 2023 11:16 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 6, 2023 11:16 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 6, 2023 11:59 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview December 6, 2023 11:59 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 29.378% (-0.04%) from 29.42%
when pulling eb3bea7 on wojciech-deriv:feature/component-test-crypto-withdrawal
into 0fe6251 on binary-com:master.

@ghost ghost merged commit 5160e8f into deriv-com:master Dec 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants