Skip to content

Conversation

@ali-hosseini-deriv
Copy link
Contributor

Changes:

This is to have the current version of released app on the dist folder in order to make sure that we are delivering and serving correct version on prod.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2023 3:59am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11984](https://github.com/binary-com/deriv-app/pull/11984)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-ako-create-version-txt-file-on-dist.binary.sx?qa_server=red.derivws.com&app_id=23837
    - **Original**: https://deriv-app-git-ako-create-version-txt-file-on-dist.binary.sx
- **App ID**: `23837`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-ako-create-version-txt-file-on-dist.binary.sx/

@coveralls
Copy link

coveralls commented Dec 4, 2023

Coverage Status

coverage: 29.64%. remained the same
when pulling 5222dfd on ako/create-version-txt-file-on-dist
into 5e49547 on master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ali-hosseini-deriv ali-hosseini-deriv merged commit f26712a into master Dec 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv deleted the ako/create-version-txt-file-on-dist branch July 3, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants