Farabi/bot 1148/fix UI bug of qs description #12002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ancement' into farabi/bot-1144/ui-bug-fix-for-qs-long-description
…ancement' into farabi/bot-1144/ui-bug-fix-for-qs-long-description
farabi-deriv
requested review from
prince-deriv,
sandeep-deriv and
vinu-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed!
|
sandeep-deriv
approved these changes
Dec 5, 2023
sandeep-deriv
merged commit 077dea6
into
deriv-com:feature/bot-qs-description-enhancement
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-1148fix-ui-bu-1e5381.binary.sx/ |
sandeep-deriv
added a commit
that referenced
this pull request
Dec 6, 2023
…1861) * [BOT] Farabi/bot 909/long description tab for martingale (#11745) * feat: added description tab and long description for martingale * fix: removed dbot icons from icons.js * fix: added description tab on qs for responsive view * fix: created a separate component for content loading * feat: updated render technique of long description and unified description (#11895) * feat: qs add long description for oscar's grind (#11900) * [BOT] Fix/martingale description config refactor (#11905) * fix: updated martingale strategy config * chore: removed martingale png file and added svg file * Sandeep/bot 912/add long description for oscars grind 2 (#11917) * chore: removed unused images from the bot * feat: qs long description mobile padding fix * Sandeep/bot 912/add long description for oscars grind 2 (#11941) * chore: removed unused images from the bot * feat: qs long description mobile padding fix * feat: add long description for qs, added common tabs component * Sandeep/bot 912/add long description for oscars grind 2 (#11948) * chore: removed unused images from the bot * feat: qs long description mobile padding fix * feat: add long description for qs, added common tabs component * feat: add long description, fixed mobile switching issue * Sandeep/bot 912/add long description for oscars grind 2 (#11950) * chore: removed unused images from the bot * feat: qs long description mobile padding fix * feat: add long description for qs, added common tabs component * feat: add long description, fixed mobile switching issue * chore: trying to fix sonar cloud warning * feat: added stying for the combined description groups qs long description * [BOT]/Maryia/feat: add long description for D'Alembert for QS modal (#11928) * feat: add long description for D'Alembert for QS modal * feat: improve styles of long description as per design * chore: remove commented code * Revert "feat: improve styles of long description as per design" This reverts commit ea85546. * Revert "chore: remove commented code" This reverts commit 7f50f6a. * fix: change styles with prop className in config * [BOT] Farabi/bot 1144/UI bug fix for qs long description (#11982) * fix: ui issues such as image visibility on dark theme and content * fix: dalembert image on dark theme and content * Farabi/bot 1148/fix UI bug of qs description (#12002) * fix: ui issues such as image visibility on dark theme and content * fix: dalembert image on dark theme and content * fix: long description content update --------- Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: maryia-matskevich-deriv <103181650+maryia-matskevich-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updated long description content as per design for D'alembert and oscars grind strategies in quick strategies description tab