Skip to content

Conversation

@ameerul-deriv
Copy link
Contributor

@ameerul-deriv ameerul-deriv commented Dec 6, 2023

Changes:

Please provide a summary of the change.

  • Moved mock-data file to my-ads folder in pages as it wasn't moved prior, when we changed the folder structure

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 6, 2023 4:42am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@coveralls
Copy link

coveralls commented Dec 6, 2023

Coverage Status

coverage: 29.828% (+0.007%) from 29.821%
when pulling 996d61a on ameerul-deriv:P2PS-2010-move-mock-data-file
into abe9020 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12043](https://github.com/binary-com/deriv-app/pull/12043)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2010-move-mock-data-file.binary.sx?qa_server=red.derivws.com&app_id=23815
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2010-move-mock-data-file.binary.sx
- **App ID**: `23815`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-2010-move-mock-data-file.binary.sx/

@farrah-deriv farrah-deriv merged commit 54a637d into deriv-com:master Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants