[P2PS] farrah/P2PS-2014/Mandatory poa for new p2p users #12100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-farrah-deriv-p2ps-2014-mandatory-poa.binary.sx/ |
nada-deriv
reviewed
Dec 8, 2023
packages/p2p/src/components/modal-manager/modals/nickname-modal/nickname-modal.scss
Outdated
Show resolved
Hide resolved
nada-deriv
reviewed
Dec 8, 2023
packages/p2p/src/components/modal-manager/modals/nickname-modal/nickname-modal.tsx
Show resolved
Hide resolved
nada-deriv
reviewed
Dec 8, 2023
packages/p2p/src/components/modal-manager/modals/nickname-modal/nickname-modal.tsx
Outdated
Show resolved
Hide resolved
nada-deriv
reviewed
Dec 8, 2023
nada-deriv
reviewed
Dec 8, 2023
nada-deriv
reviewed
Dec 8, 2023
nada-deriv
reviewed
Dec 8, 2023
packages/p2p/src/components/modal-manager/modals/nickname-modal/nickname-modal.tsx
Outdated
Show resolved
Hide resolved
maryia-deriv
previously approved these changes
Dec 15, 2023
ameerul-deriv
approved these changes
Jan 2, 2024
|
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Contributor
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
Contributor
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
We will require users to submit proof of address before accessing P2P. The new flow for verification is included here where user needs to submit proof of identity, proof of address, then provide a nickname.
Screenshots: