Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

Changes:

Unit test for WalletError component

Screenshots:

image

@vercel
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 8, 2023 3:48am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12124](https://github.com/binary-com/deriv-app/pull/12124)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-unit-test-w-f922b7.binary.sx?qa_server=red.derivws.com&app_id=24256
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-unit-test-w-f922b7.binary.sx
- **App ID**: `24256`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-unit-test-w-f922b7.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 30.415% (+0.07%) from 30.341%
when pulling 8eb7b80 on farhan-nurzi-deriv:farhan/unit-test-wallet-error
into 2a99e7b on binary-com:master.

@yashim-deriv yashim-deriv merged commit 23ba639 into deriv-com:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants