Skip to content

Conversation

@amina-deriv
Copy link
Contributor

@amina-deriv amina-deriv commented Dec 12, 2023

Changes:

Removing extra spacing for address form for CR clients

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 12, 2023 1:18pm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.2% 8.2% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12191](https://github.com/binary-com/deriv-app/pull/12191)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-webrel-1756.binary.sx?qa_server=red.derivws.com&app_id=32678
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-webrel-1756.binary.sx
- **App ID**: `32678`

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-webrel-1756.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 31.309%. remained the same
when pulling c0615e9 on amina-deriv:amina/WEBREL-1756
into b7f2b62 on binary-com:master.

@hamza-deriv hamza-deriv merged commit baa25e4 into deriv-com:master Dec 13, 2023
hamza-deriv pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants