Skip to content

Conversation

@ali-hosseini-deriv
Copy link
Contributor

@ali-hosseini-deriv ali-hosseini-deriv commented Dec 13, 2023

Changes:

This is to initiate P2P-V2 package in monorepo.

Screenshots:

image Screenshot 2023-12-13 at 4 49 21 PM

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 21, 2023 11:32am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12218](https://github.com/binary-com/deriv-app/pull/12218)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-initiate-p2p-v2.binary.sx?qa_server=red.derivws.com&app_id=24075
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-initiate-p2p-v2.binary.sx
- **App ID**: `24075`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-initiate-p2p-v2.binary.sx/

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
6.8% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@ali-hosseini-deriv ali-hosseini-deriv merged commit 7058e4f into deriv-com:master Dec 22, 2023
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
* feat: add p2p v2 to core routes

* feat: scaffold p2p-v2

* feat: add lazy loader utils

* feat: add router

* feat: add new home page and routing

* build: add stylelint conf

* build: reorder the webpack config entries

* chore: add EOF

* feat: add inner page to core route

* feat: add cashier p2p-v2 route

* feat: add p2p-v2 to cashier and fix routing

* feat: add feature flag for p2p-v2

* feat: remove p2p-v2 from cashier

* build: add deriv-api as externals

* feat: spread the item instead of copy

* fix: fix the inifinite add route in cashier

* build: update package lock

* fix: revert icons

* fix: revert icons

Signed-off-by: lubega-deriv <lubega@deriv.com>
lubega-deriv pushed a commit to lubega-deriv/deriv-app that referenced this pull request Dec 26, 2023
* feat: add p2p v2 to core routes

* feat: scaffold p2p-v2

* feat: add lazy loader utils

* feat: add router

* feat: add new home page and routing

* build: add stylelint conf

* build: reorder the webpack config entries

* chore: add EOF

* feat: add inner page to core route

* feat: add cashier p2p-v2 route

* feat: add p2p-v2 to cashier and fix routing

* feat: add feature flag for p2p-v2

* feat: remove p2p-v2 from cashier

* build: add deriv-api as externals

* feat: spread the item instead of copy

* fix: fix the inifinite add route in cashier

* build: update package lock

* fix: revert icons

* fix: revert icons

Signed-off-by: lubega-deriv <lubega@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants