Skip to content

Conversation

@ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Added label 'Currency' to the currency dropdown

Screenshots:

Please provide some screenshots of the change.
Screenshot 2023-12-20 at 10 55 31 AM

@vercel
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 3:36am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12387](https://github.com/binary-com/deriv-app/pull/12387)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-981-add-title-for-49895a.binary.sx?qa_server=red.derivws.com&app_id=32205
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-981-add-title-for-49895a.binary.sx
- **App ID**: `32205`

@coveralls
Copy link

coveralls commented Dec 20, 2023

Coverage Status

coverage: 34.65% (+1.1%) from 33.504%
when pulling cba48ab on ameerul-deriv:P2PS-981-add-title-for-currency-dropdown
into 76438ec on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 69
🟧 Best practices 83
🟢 SEO 100
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-981-add-title-for-49895a.binary.sx/

farrah-deriv
farrah-deriv previously approved these changes Dec 26, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit 0124857 into deriv-com:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants