Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Dec 28, 2023

Changes:

  • Add account loginid to query param when redirecting from the account listing
  • Set toAccount value if query param and account with given loginid exist

Screenshots:

Screen.Recording.2023-12-28.at.10.35.25.AM.mov

@vercel
Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 28, 2023 8:01am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12563](https://github.com/binary-com/deriv-app/pull/12563)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3040tr-b3d4f7.binary.sx?qa_server=red.derivws.com&app_id=24063
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3040tr-b3d4f7.binary.sx
- **App ID**: `24063`

@coveralls
Copy link

coveralls commented Dec 28, 2023

Coverage Status

coverage: 33.98% (-0.03%) from 34.012%
when pulling 268dc20 on farhan-nurzi-deriv:farhan/WALL-3040/trasnfer-to-account-not-selected
into 3b3f1b4 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3040tr-b3d4f7.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.2% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 7a48b59 into deriv-com:master Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants