Skip to content

Conversation

@sandeep-deriv
Copy link
Contributor

@sandeep-deriv sandeep-deriv commented Jan 2, 2024

Changes:

UI Bug fixing and style file refactoring

  • Align user guide icon
  • Max stake +/- are not disabled when max stake is disabled
  • Bot builder tour on responsive doesn't collapse
  • Dix Responsive gaps and extra spaces from bot-builder
  • Blocks getting cropped from top fix in bot builder
  • Removed duplicate Recent label from load modal
  • Removed extra gutter space from the recent bot label
  • Fixed bot label overlapping on load modal
  • More actions icon was sticking to the load type fix on dashboard tab

review-deriv

This comment was marked as resolved.

@boring-cyborg boring-cyborg bot added the Bot label Jan 2, 2024
@vercel
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 10, 2024 5:26am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12678](https://github.com/binary-com/deriv-app/pull/12678)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-1174bot-ui-6cbec5.binary.sx?qa_server=red.derivws.com&app_id=24101
    - **Original**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-1174bot-ui-6cbec5.binary.sx
- **App ID**: `24101`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-1174bot-ui-6cbec5.binary.sx/

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
4.8% Duplication on New Code

See analysis details on SonarCloud

@sandeep-deriv sandeep-deriv merged commit b8ef5d5 into deriv-com:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants