Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Implement the Instrument with Label component in the Traders Hub Package

Screenshots:

Please provide some screenshots of the change.

image

@vercel
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 3, 2024 4:17am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12680](https://github.com/binary-com/deriv-app/pull/12680)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2566instrument-cf4d9c.binary.sx?qa_server=red.derivws.com&app_id=32109
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2566instrument-cf4d9c.binary.sx
- **App ID**: `32109`

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 34.203% (-0.002%) from 34.205%
when pulling 1ba39e9 on hamza-deriv:hamza/TRAH-2566/Instrument-icon-with-label
into f805018 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-trah-2566instrument-cf4d9c.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
68.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@hirad-deriv hirad-deriv merged commit 4e4aeb4 into deriv-com:master Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants