Skip to content

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Jan 3, 2024

Changes:

Fix This is very common password error not shown in password field

Screenshots:

image

@vercel
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 3, 2024 10:07am

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 34.229% (+0.008%) from 34.221%
when pulling 2e1492c on farhan-nurzi-deriv:farhan/WALL-3086/error-message-not-shown
into 774cefe on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12701](https://github.com/binary-com/deriv-app/pull/12701)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3086er-33b91d.binary.sx?qa_server=red.derivws.com&app_id=24043
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3086er-33b91d.binary.sx
- **App ID**: `24043`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-3086er-33b91d.binary.sx/

ghost
ghost previously approved these changes Jan 3, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests tests? :D:D:D

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
6.2% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 283a132 into deriv-com:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants