Skip to content

Conversation

@ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Added new custom type string to the custom type array as Mobile is appending custom types to the message tied to the order id for notifications.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 12, 2024 8:35am

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 34.634% (-0.005%) from 34.639%
when pulling 382c34b on ameerul-deriv:P2PS-2194-chat-message-disappearing-mobile-to-web
into b03ebde on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12706](https://github.com/binary-com/deriv-app/pull/12706)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2194-chat-message-ea256c.binary.sx?qa_server=red.derivws.com&app_id=32933
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2194-chat-message-ea256c.binary.sx
- **App ID**: `32933`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-2194-chat-message-ea256c.binary.sx/

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
6.6% Duplication on New Code

See analysis details on SonarCloud

@farrah-deriv farrah-deriv merged commit 529451f into deriv-com:master Feb 9, 2024
vinu-deriv pushed a commit to vinu-deriv/deriv-app that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants