Skip to content

Conversation

@aum-deriv
Copy link
Contributor

Changes:

🐛 Bugs Fixed:

  1. Showing the daily cumulative transfer limits positive message to a verified user when they are performing transfer between wallets.
  2. Use the internal key from the get_limits response for showing the daily cumulative limits between wallets instead of the wallet key (wallet key is for limit between currency wallets and special wallets like P2P and PA).
    image
image

@vercel
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 5:44am

…L-3201/verified-user-daily-limits-transfer-between-wallets
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12711](https://github.com/binary-com/deriv-app/pull/12711)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-3201verified-user-d8b996.binary.sx?qa_server=red.derivws.com&app_id=32113
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-3201verified-user-d8b996.binary.sx
- **App ID**: `32113`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-3201verified-user-d8b996.binary.sx/

@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 34.24% (-0.001%) from 34.241%
when pulling 6f009cb on aum-deriv:aum/WALL-3201/verified-user-daily-limits-transfer-between-wallets
into 9e1c725 on binary-com:master.

…L-3201/verified-user-daily-limits-transfer-between-wallets
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
11.1% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@aum-deriv aum-deriv marked this pull request as ready for review January 4, 2024 06:06
@aum-deriv aum-deriv requested a review from a user January 4, 2024 06:06
@aum-deriv aum-deriv changed the title [Draft] [WALL] Aum/WALL-3201/verified-user-daily-limits-transfer-between-wallets [WALL] Aum/WALL-3201/verified-user-daily-limits-transfer-between-wallets Jan 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Generating Lighthouse report...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 535ca35 into deriv-com:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants