Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

Description:

Implement the InstrumentsLabelHighlighted inside TradersHub Package

Screenshots:

image

@vercel
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 5:39am

…RAH-2612/instruments-label-highlighted-component
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12725](https://github.com/binary-com/deriv-app/pull/12725)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2612instrument-055624.binary.sx?qa_server=red.derivws.com&app_id=32925
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-trah-2612instrument-055624.binary.sx
- **App ID**: `32925`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-trah-2612instrument-055624.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Jan 4, 2024

Coverage Status

coverage: 34.248% (+0.007%) from 34.241%
when pulling 0031df2 on hamza-deriv:hamza/TRAH-2612/instruments-label-highlighted-component
into 9e1c725 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

@shontzu-deriv shontzu-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hirad-deriv hirad-deriv merged commit 1bfb0f7 into deriv-com:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants