Skip to content

Conversation

@NikitK-deriv
Copy link
Contributor

@NikitK-deriv NikitK-deriv commented Jan 9, 2024

Changes:

As a developer and analyst I want see only proper and clear data in database, also I want to prevent extra page and identify calls when it's unnecessary.
To reach the first value we have to refactor existing setup and be sure that we send only data, without null and undefined properties. Also to reach the second value, we have to minify event calls and set them only when needed from business perspective (i.e. user authorised, change wallet, etc.)

Screenshots:

Should provide all data on each track event, without nulls and undefined:
Screenshot 2024-01-09 at 11 20 58

Page event should call on each route change:
Screenshot 2024-01-09 at 11 21 05

experiment_view event aka a/b testing feature appeared should pass directly to google analytics:
Screenshot 2024-01-09 at 11 28 36

@vercel
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 25, 2024 7:22am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12837](https://github.com/binary-com/deriv-app/pull/12837)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nikitk-deriv-cro-nikitk-387-fix-for-d-a3d212.binary.sx?qa_server=red.derivws.com&app_id=24254
    - **Original**: https://deriv-app-git-fork-nikitk-deriv-cro-nikitk-387-fix-for-d-a3d212.binary.sx
- **App ID**: `24254`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-nikitk-deriv-cro-nikitk-387-fix-for-d-a3d212.binary.sx/

@coveralls
Copy link

coveralls commented Jan 9, 2024

Coverage Status

coverage: 34.868% (+0.05%) from 34.822%
when pulling 0eed944 on NikitK-deriv:cro-nikitk-387-fix-for-data-layer
into 796e4f0 on binary-com:master.

heorhi-deriv
heorhi-deriv previously approved these changes Jan 24, 2024
@ali-hosseini-deriv
Copy link
Contributor

image this one missed @NikitK-deriv please change it and regenerate the package-lock.json using `npm run clean && npm run bootstrap:dev`

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv merged commit 595cdc8 into deriv-com:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants