-
Notifications
You must be signed in to change notification settings - Fork 394
[CRO] Fix for data layer: deviсe and account type data is null, minifying page and identify events for rudderstack, add country and language context for growthbook #12837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-nikitk-deriv-cro-nikitk-387-fix-for-d-a3d212.binary.sx/ |
this one missed @NikitK-deriv
please change it and regenerate the package-lock.json using `npm run clean && npm run bootstrap:dev`
|
|
|
⏳ Generating Lighthouse report... |


Changes:
As a developer and analystI want see only proper and clear data in database, also I want to prevent extra page and identify calls when it's unnecessary.To reach the
first valuewe have to refactor existing setup and be sure that we send only data, without null and undefined properties. Also to reach thesecond value, we have to minify event calls and set them only when needed from business perspective (i.e. user authorised, change wallet, etc.)Screenshots:
Should provide all data on each

track event, without nulls and undefined:Page eventshould call on each route change:experiment_viewevent akaa/b testing featureappeared should pass directly to google analytics: