Skip to content

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Jan 11, 2024

Changes:

  • Created a reusable component layout within the TradingAccountCardComponent and used across Options and Multipliers, MT5, Deriv X and CTrader accounts.
  • Created a coral light button
  • Fix alignment issues and some other minor tweaks
  • All of the changes above supports different screen sizes

Screenshots:

Screen.Recording.2024-01-11.at.6.11.03.PM.mov

@aizad-deriv aizad-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Jan 11, 2024
@aizad-deriv aizad-deriv self-assigned this Jan 11, 2024
@vercel
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 11, 2024 10:24am

@coveralls
Copy link

coveralls commented Jan 11, 2024

Coverage Status

coverage: 34.581% (+0.002%) from 34.579%
when pulling 5ec8973 on aizad-deriv:aizad/TRAH-2651/trading-app-card
into 24bb142 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12899](https://github.com/binary-com/deriv-app/pull/12899)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-trah-2651trading-app-card.binary.sx?qa_server=red.derivws.com&app_id=23831
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-trah-2651trading-app-card.binary.sx
- **App ID**: `23831`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-trah-2651trading-app-card.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@hamza-deriv hamza-deriv merged commit fb0b76e into deriv-com:master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants