Skip to content

Conversation

@lubega-deriv
Copy link
Contributor

Changes:

  • Added unit test for IDVDocumentUploadDetails
  • Added checkbox to IDVDocumentUploadDetails to verify inputted details
  • Disabled inputs in IDVDocumentUploadDetails when checkbox checked
  • Updated first name and last name validators

Screenshots:

image
Screen.Recording.2024-01-15.at.7.52.24.PM.mov
Screen.Recording.2024-01-15.at.7.53.48.PM.mov

@vercel
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 17, 2024 10:49am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12957](https://github.com/binary-com/deriv-app/pull/12957)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3305-idv-document-u-bf81d2.binary.sx?qa_server=red.derivws.com&app_id=24200
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3305-idv-document-u-bf81d2.binary.sx
- **App ID**: `24200`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3305-idv-document-u-bf81d2.binary.sx/

@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 34.785% (+0.2%) from 34.633%
when pulling 7ca85a3 on lubega-deriv:WALL-3305/idv-document-upload-details-checkbox
into 20d8702 on binary-com:master.

@sweep-ai-deprecated
Copy link

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

nijil-deriv
nijil-deriv previously approved these changes Jan 16, 2024
yashim-deriv
yashim-deriv previously approved these changes Jan 17, 2024
adrienne-deriv
adrienne-deriv previously approved these changes Jan 17, 2024
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nijil-deriv nijil-deriv merged commit e40dd38 into deriv-com:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants