Skip to content

Conversation

@mahdiyeh-deriv
Copy link
Contributor

@mahdiyeh-deriv mahdiyeh-deriv commented Jan 18, 2024

Changes:

  • Remove onboarding flow after signup
  • Tour guide is removed after singup
  • Empty screen with logo is in the onboarding url is using for signup flow
  • View onboarding icon is removed from header, it will be visible when wallets flag is enabled

Screenshots:

Please provide some screenshots of the change.

Screenshare.-.2024-02-08.3_05_43.AM.mp4

@vercel
Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 12, 2024 7:24am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13042](https://github.com/binary-com/deriv-app/pull/13042)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mahdiyeh-deriv-mahdiyeh-removeonboarding.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-mahdiyeh-deriv-mahdiyeh-removeonboarding.binary.sx
- **App ID**: `23835`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mahdiyeh-deriv-mahdiyeh-removeonboarding.binary.sx/

@coveralls
Copy link

coveralls commented Jan 19, 2024

Coverage Status

coverage: 37.551% (+0.07%) from 37.486%
when pulling 2be9c1f on mahdiyeh-deriv:mahdiyeh/remove_onboarding
into d59eb14 on binary-com:master.

@mahdiyeh-deriv mahdiyeh-deriv marked this pull request as ready for review January 19, 2024 08:24
@mahdiyeh-deriv mahdiyeh-deriv changed the title Mahdiyeh/ chore: Remove onboarding [TRAH]- 2657/ Mahdiyeh/ chore: Remove onboarding Jan 19, 2024
@aizad-deriv
Copy link
Contributor

Fix tour issue where it will not show background overlay and will not run after going through onboarding multiple of times:

Screen.Recording.2024-02-14.at.5.21.25.PM.mov

matin-deriv
matin-deriv previously approved these changes Feb 15, 2024
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

hirad-deriv
hirad-deriv previously approved these changes Feb 15, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.5% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit c9390eb into deriv-com:master Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants