Skip to content

Conversation

@shafin-deriv
Copy link
Contributor

@shafin-deriv shafin-deriv commented Jan 19, 2024

Crash and Boom need to be disabled from the Bot Builder. It was already disabled in the Quick Strategy.

Changes:

  • Added crash_index inside the DISABLED_SUBMARKETS array of the bot-skeleton config file.

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 19, 2024 9:37am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13060](https://github.com/binary-com/deriv-app/pull/13060)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-botchore-remove-c-eedb58.binary.sx?qa_server=red.derivws.com&app_id=32920
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-botchore-remove-c-eedb58.binary.sx
- **App ID**: `32920`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-botchore-remove-c-eedb58.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
7.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Jan 19, 2024

Coverage Status

coverage: 34.213% (-0.6%) from 34.771%
when pulling 038da2e on shafin-deriv:shafin/BOT/chore--remove-crash-boom
into ce1dadc on binary-com:master.

@github-actions
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants