Skip to content

Conversation

@amina-deriv
Copy link
Contributor

Changes:

Add checkbox for spain clients in real account signup form

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 7, 2024 11:00am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13114](https://github.com/binary-com/deriv-app/pull/13114)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-coj445confirmationc-2c6301.binary.sx?qa_server=red.derivws.com&app_id=23938
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-coj445confirmationc-2c6301.binary.sx
- **App ID**: `23938`

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-coj445confirmationc-2c6301.binary.sx/

@coveralls
Copy link

coveralls commented Jan 24, 2024

Coverage Status

coverage: 37.452% (+0.06%) from 37.388%
when pulling ba3ca29 on amina-deriv:amina/coj_445/confirmation_checkbox_for_spanish_residents
into b653a67 on binary-com:master.

…oj_445/confirmation_checkbox_for_spanish_residents
…oj_445/confirmation_checkbox_for_spanish_residents
@amina-deriv amina-deriv changed the title [BLOCKED][COJ]/Amina/COJ-445/feat: add confirmation checkbox for spanish residents [COJ]/Amina/COJ-445/feat: add confirmation checkbox for spanish residents Mar 1, 2024
matin-deriv
matin-deriv previously approved these changes Mar 5, 2024
…oj_445/confirmation_checkbox_for_spanish_residents
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Generating Lighthouse report...

@farabi-deriv farabi-deriv merged commit f80071b into deriv-com:master Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants