[WALL] Farhan/WALL-2063/User wallet migration banner & modal #13149

farhan-nurzi-deriv · 2024-01-26T01:30:15Z

Changes:

Implement wallet upgrade banner and modal in tradershub.

Screenshots:

[ Updated content ]

Screen.Recording.2024-01-26.at.9.22.12.AM.mov

vercel · 2024-01-26T01:30:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Feb 7, 2024 7:12am

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

github-actions · 2024-01-26T01:44:54Z

A production App ID was automatically generated for this PR. (log)

PR: [WALL] Farhan/WALL-2063/User wallet migration banner & modal #13149
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-2063us-422c93.binary.sx?qa_server=red.derivws.com&app_id=24035
- Original: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-2063us-422c93.binary.sx
App ID: 24035

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/13149](https://github.com/binary-com/deriv-app/pull/13149)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-2063us-422c93.binary.sx?qa_server=red.derivws.com&app_id=24035
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-2063us-422c93.binary.sx
- **App ID**: `24035`

github-actions · 2024-01-26T01:45:15Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	28
🟧 Accessibility	89
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-wall-2063us-422c93.binary.sx/

coveralls · 2024-01-26T01:49:32Z

coverage: 35.41% (+0.01%) from 35.4%
when pulling a5dc0fd on farhan-nurzi-deriv:farhan/WALL-2063/user-wallet-migration-banner-and-modal
into 37d2705 on binary-com:master.

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

packages/appstore/src/components/modals/wallets-upgrade-modal/wallets-upgrade-modal.tsx

packages/appstore/src/components/wallets-banner/wallets-banner-upgrade.tsx

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

sonarqubecloud · 2024-02-07T06:51:42Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

16 New issues
0 Security Hotspots
No data about Coverage
4.1% Duplication on New Code

See analysis details on SonarCloud

…om#13149) * feat: ✨ wallet migration banner and modal * chore: 🧹 remove unused import * chore: 🧹 add test cases * chore: ✨ update content * fix: 🔧 update test * chore: ✨ add TODO comments * fix: 🔧 checking active loginid from localstorage instead of authorize hook to prevent extra calls * refactor: 🔧 styles * fix: 🔧 using hook from hooks package to prevent logout * fix: 🔧 logout when new connection open * fix: 🔧 using localstorage instead of sessionstorage * fix: 🔧 imports from hooks instead of api * fix: 🔧 failing tests * fix: 🔧 incorporate new design * fix: 🔧 failing tests

feat: ✨ wallet migration banner and modal

1249535

farhan-nurzi-deriv requested review from mahdiyeh-deriv, matin-deriv and nijil-deriv as code owners January 26, 2024 01:30

boring-cyborg bot added the AppStore label Jan 26, 2024

farhan-nurzi-deriv temporarily deployed to Preview January 26, 2024 01:31 — with GitHub Actions Inactive

Farhan-slurrp added 2 commits January 26, 2024 09:43

chore: 🧹 remove unused import

a545195

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

f6e5dec

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

farhan-nurzi-deriv temporarily deployed to Preview January 26, 2024 01:45 — with GitHub Actions Inactive

chore: 🧹 add test cases

e06447d

farhan-nurzi-deriv temporarily deployed to Preview January 26, 2024 02:24 — with GitHub Actions Inactive

chore: ✨ update content

06dcf21

farhan-nurzi-deriv temporarily deployed to Preview January 29, 2024 07:24 — with GitHub Actions Inactive

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

9fb020c

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

farhan-nurzi-deriv temporarily deployed to Preview January 29, 2024 07:41 — with GitHub Actions Inactive

fix: 🔧 update test

1a0d84e

farhan-nurzi-deriv temporarily deployed to Preview January 29, 2024 07:43 — with GitHub Actions Inactive

nijil-deriv reviewed Jan 29, 2024

View reviewed changes

packages/appstore/src/components/modals/wallets-upgrade-modal/wallets-upgrade-modal.tsx Show resolved Hide resolved

packages/appstore/src/components/wallets-banner/wallets-banner-upgrade.tsx Show resolved Hide resolved

ghost previously approved these changes Jan 29, 2024

View reviewed changes

chore: ✨ add TODO comments

2462a5b

farhan-nurzi-deriv temporarily deployed to Preview February 2, 2024 03:46 — with GitHub Actions Inactive

fix: 🔧 using localstorage instead of sessionstorage

e28028a

farhan-nurzi-deriv requested a review from maryia-deriv as a code owner February 5, 2024 07:47

boring-cyborg bot added the Core label Feb 5, 2024

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

fea618a

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

farhan-nurzi-deriv temporarily deployed to Preview February 5, 2024 07:47 — with GitHub Actions Inactive

farhan-nurzi-deriv temporarily deployed to Preview February 5, 2024 07:49 — with GitHub Actions Inactive

Farhan-slurrp added 2 commits February 6, 2024 16:01

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

368cc1a

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

fix: 🔧 imports from hooks instead of api

7d48972

farhan-nurzi-deriv temporarily deployed to Preview February 6, 2024 08:13 — with GitHub Actions Inactive

farhan-nurzi-deriv temporarily deployed to Preview February 6, 2024 08:14 — with GitHub Actions Inactive

Farhan-slurrp added 2 commits February 6, 2024 16:36

fix: 🔧 failing tests

28d7de5

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

a756bf9

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

farhan-nurzi-deriv temporarily deployed to Preview February 6, 2024 08:39 — with GitHub Actions Inactive

fix: 🔧 incorporate new design

191f19d

farhan-nurzi-deriv temporarily deployed to Preview February 7, 2024 02:56 — with GitHub Actions Inactive

Farhan-slurrp added 2 commits February 7, 2024 14:47

fix: 🔧 failing tests

fa5a151

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

a5dc0fd

… farhan/WALL-2063/user-wallet-migration-banner-and-modal

farhan-nurzi-deriv temporarily deployed to Preview February 7, 2024 06:49 — with GitHub Actions Inactive

nijil-deriv approved these changes Feb 14, 2024

View reviewed changes

ghost approved these changes Feb 14, 2024

View reviewed changes

nijil-deriv merged commit 6f15c2b into deriv-com:master Feb 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WALL] Farhan/WALL-2063/User wallet migration banner & modal #13149

[WALL] Farhan/WALL-2063/User wallet migration banner & modal #13149

Uh oh!

farhan-nurzi-deriv commented Jan 26, 2024 •

edited

Loading

Uh oh!

vercel bot commented Jan 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 26, 2024 •

edited

Loading

Uh oh!

coveralls commented Jan 26, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[WALL] Farhan/WALL-2063/User wallet migration banner & modal #13149

[WALL] Farhan/WALL-2063/User wallet migration banner & modal #13149

Uh oh!

Conversation

farhan-nurzi-deriv commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Screenshots:

[ Updated content ]

Uh oh!

vercel bot commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 7, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

farhan-nurzi-deriv commented Jan 26, 2024 •

edited

Loading

vercel bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

github-actions bot commented Jan 26, 2024 •

edited

Loading

coveralls commented Jan 26, 2024 •

edited

Loading