Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

@hamza-deriv hamza-deriv commented Jan 26, 2024

Changes:

Please provide a summary of the change.

Description:

We want to change the company for each one of the 5 White Label. Clients can login to any of the WLs as the required fields are server, login and Password. We are not going to change server names.

Clients might have multiple accounts under different entities, but they will be able to login to any of the available companies with any of their accounts. 

The reason for this change is related to regulations and nothing is changing regarding clients ability to login to their MT5 account. 

Screenshots:

Please provide some screenshots of the change.
image

@vercel
Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 5, 2024 6:42am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13169](https://github.com/binary-com/deriv-app/pull/13169)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1447download-l-f4c0a9.binary.sx?qa_server=red.derivws.com&app_id=32679
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1447download-l-f4c0a9.binary.sx
- **App ID**: `32679`

@coveralls
Copy link

coveralls commented Jan 26, 2024

Coverage Status

coverage: 34.932% (-0.004%) from 34.936%
when pulling c7c277f on hamza-deriv:hamza/CFDS-1447/download-links-for-windows-playstore-ios
into 5cb4656 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1447download-l-f4c0a9.binary.sx/

…FDS-1447/download-links-for-windows-playstore-ios
@shontzu-deriv
Copy link
Contributor

Interesting that the link for Windows and Android is coming from the API but the rest are still in fe 😅🤔 anyways lgtm

@hamza-deriv hamza-deriv changed the title [CFDS] Hamza/CFDS-1447/Added dynamic links for windows ios and playstore [CFDS] Hamza/CFDS-1447/Added dynamic links for windows ios and playstore and dynamic brokername Feb 2, 2024
…FDS-1447/download-links-for-windows-playstore-ios
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Generating Lighthouse report...

@hamza-deriv hamza-deriv merged commit e821b1f into deriv-com:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants